Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: the search box is missing #147

Open
alabulei1 opened this issue Aug 17, 2023 · 2 comments
Open

Feature Request: the search box is missing #147

alabulei1 opened this issue Aug 17, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alabulei1
Copy link
Collaborator

alabulei1 commented Aug 17, 2023

Once we have a search box for the docs. See the PR #31

However the search box is missing now. I'm not sure which PR removes the search box. We need to add this feature again.

@masterghost2002
Copy link
Contributor

masterghost2002 commented Aug 18, 2023

fixed->issue:147 search bar missing, reason:themes:[ Array ] in config consisting of localsearch is over written by themes [Array] in extendedConfig

Explanation

All the changes are done in docusaurus.config.js

The reason for the search bar is not visible the, themes array [line no 62] in the config object which again consist a array of "@easyops-cn/docusaurus-search-local" the extension which is responsible for the search bar, is being overwritten by the array in extendedConfig object.

Related issue

fixes#147

What type of PR is this

/fixes
/feature-required

PR Link

Proposed Changes

Merge the themes array present in the extendedConfig object which overwrites the themes array present in config object.

Live link for testing

Live Testing Link

ScreenShot

Screenshot from 2023-08-18 09-58-41

@adithyaakrishna
Copy link
Contributor

@alabulei1 Can we please close this Issue as it is fixed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants